Thesharing opened a new pull request #16686:
URL: https://github.com/apache/flink/pull/16686


   ## What is the purpose of the change
   
   *JobVertex#connectIdInput is not used in production anymore. It's only used 
in the unit tests testAttachViaIds and testCannotConnectMissingId located in 
DefaultExecutionGraphConstructionTest. However, these two test cases are 
designed to test this method. Therefore, this method and its test cases can be 
removed. For more details please check FLINK-23599.*
   
   
   ## Brief change log
   
     - *Remove JobVertex#connectIdInput*
     - *Remove DefaultExecutionGraphConstructionTest#testAttachViaIds and 
testCannotConnectMissingId*
     - *Fix checkstyle in JobVertex.java and 
DefaultExecutionGraphConstructionTest.java*
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (**yes** / no / don't 
know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to