godfreyhe commented on a change in pull request #16599:
URL: https://github.com/apache/flink/pull/16599#discussion_r681658127
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/LogicalTypeJsonDeserializer.java
##########
@@ -130,6 +139,11 @@ public LogicalType deserialize(JsonNode logicalTypeNode,
SerdeContext serdeCtx)
return deserializeArrayType(logicalTypeNode, serdeCtx);
case MULTISET:
return deserializeMultisetType(logicalTypeNode, serdeCtx);
+ case RAW:
+ // This method only deserializes the LogicalType with
`type='RAW'`,
Review comment:
nope, the fallback means `deserializeRawType` method only handles
`LogicalType with `type='RAW'`, otherwise it will be handled by
`LogicalTypeParser.parse(logicalTypeNode.asText())`, see line#155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
