zhuzhurk commented on a change in pull request #16465:
URL: https://github.com/apache/flink/pull/16465#discussion_r681674908
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/JobMasterPartitionTracker.java
##########
@@ -39,7 +39,8 @@ void startTrackingPartition(
ResultPartitionDeploymentDescriptor
resultPartitionDeploymentDescriptor);
/** Releases the given partitions and stop the tracking of partitions that
were released. */
- void stopTrackingAndReleasePartitions(Collection<ResultPartitionID>
resultPartitionIds);
+ void stopTrackingAndReleasePartitions(
Review comment:
Maybe keep the old method and add this as a new one, with default
implementation that `releaseOnShuffleMaster` is true?
I think the second param is not easy for understanding so I prefer to not
force set it unless necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
