XComp commented on pull request #15898:
URL: https://github.com/apache/flink/pull/15898#issuecomment-891805950


   > Regarding using `ExceptionHistoryEntryMatcher`, I'm not sure what exact 
timestamp to expect. Maybe it's best to stick with the range that's in the test 
now without the matcher?
   > 
   > FYI I uploaded the changes, I had made before vacation, that I think 
addressed the review. I'd like to see what the integration test runs do, since 
developing on windows makes it hard to run the build.
   
   The same way, how you get the `ExecutionAttemptID` in 
[AdaptiveSchedulerTest:920-924](https://github.com/apache/flink/blob/521e19eecadf39a226c5b5be4ed5348485656eab/flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java#L920-L924)
 you could also get the failure info. Just instead of calling `getAttemptId()` 
to retrieve the ID, you could call `getFailureInfo()` to retrieve the 
`ErrorInfo` which includes the timestamp after `updateTaskExecutionState` is 
called.
   
   I hope that helped.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to