[GitHub] [flink] beyond1920 commented on a change in pull request #16620: [FLINK-23246][table-planner] Refactor the time indicator materialization

Wed, 04 Aug 2021 01:33:26 -0700 


beyond1920 commented on a change in pull request #16620:
URL: https://github.com/apache/flink/pull/16620#discussion_r682406281



##########
File path: 
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/DeduplicateTest.xml
##########
@@ -207,7 +207,7 @@ LogicalProject(a=[$0], b=[$1], c=[$2], proctime=[$3], 
rowtime=[$4], rowNum=[$5])
     </Resource>
     <Resource name="optimized exec plan">
       <![CDATA[
-Calc(select=[a, b, c, PROCTIME_MATERIALIZE(proctime) AS proctime, rowtime, 
1:BIGINT AS rowNum])
+Calc(select=[a, b, c, PROCTIME_MATERIALIZE(proctime) AS proctime, rowtime, 
1:BIGINT AS $5])

Review comment:
       In the previous materialize version, the last field of the new added 
project is rowNum
   
![image](https://user-images.githubusercontent.com/1525333/128148720-30eec7cb-3080-45bf-803c-a9d24dcb4505.png)
   
   In the new version, materialize move to the later phase. after 
`project_rewrite` phase, the last field of LogicalProject rowtype is $5 instead 
of rowNum.
   So  the last field of the new added calc is $5
   
![image](https://user-images.githubusercontent.com/1525333/128148392-59d0f520-db2e-40d7-8ee7-e8b6038eacb9.png)
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to