fapaul commented on a change in pull request #16676:
URL: https://github.com/apache/flink/pull/16676#discussion_r683265825
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointTestBase.java
##########
@@ -165,35 +161,11 @@ protected File execute(UnalignedSettings settings) throws
Exception {
miniCluster.after();
}
if (settings.generateCheckpoint) {
- return Files.find(checkpointDir.toPath(), 2,
this::isCompletedCheckpoint)
- .max(Comparator.comparing(Path::toString))
- .map(Path::toFile)
- .orElseThrow(() -> new IllegalStateException("Cannot
generate checkpoint"));
+ return TestUtils.getMostRecentCompletedCheckpoint(checkpointDir);
Review comment:
This is not easily possible because I cannot add the `TestUtils`
dependency because it would introduce a cycling dependency. Therefore I left
it, for now, to not spending more time entangling the dependencies.
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointTestBase.java
##########
@@ -165,35 +161,11 @@ protected File execute(UnalignedSettings settings) throws
Exception {
miniCluster.after();
}
if (settings.generateCheckpoint) {
- return Files.find(checkpointDir.toPath(), 2,
this::isCompletedCheckpoint)
- .max(Comparator.comparing(Path::toString))
- .map(Path::toFile)
- .orElseThrow(() -> new IllegalStateException("Cannot
generate checkpoint"));
+ return TestUtils.getMostRecentCompletedCheckpoint(checkpointDir);
Review comment:
This is not easily possible because I cannot add the `TestUtils`
dependency because it would introduce a cycling dependency. Therefore I left
it, for now, to not spending more time disentangling the dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
