rkhachatryan commented on a change in pull request #16719:
URL: https://github.com/apache/flink/pull/16719#discussion_r683268095
##########
File path:
flink-dstl/flink-dstl-dfs/src/test/java/org/apache/flink/changelog/fs/BatchingStateChangeUploaderTest.java
##########
@@ -94,14 +97,23 @@ public void testSizeThreshold() throws Exception {
@Test
public void testDelay() throws Exception {
int delayMs = 50;
+ ManuallyTriggeredScheduledExecutorService scheduler =
+ new ManuallyTriggeredScheduledExecutorService();
withStore(
delayMs,
Integer.MAX_VALUE,
+ scheduler,
(store, probe) -> {
+ scheduler.triggerAll();
List<StateChangeSet> changeSets = getChanges(4);
upload(store, changeSets);
assertTrue(probe.getUploaded().isEmpty());
- Thread.sleep(delayMs * 2);
+ assertTrue(
Review comment:
The intention is to check that the delay, that it is equal to what was
configured.
##########
File path:
flink-dstl/flink-dstl-dfs/src/test/java/org/apache/flink/changelog/fs/BatchingStateChangeUploaderTest.java
##########
@@ -94,14 +97,23 @@ public void testSizeThreshold() throws Exception {
@Test
public void testDelay() throws Exception {
int delayMs = 50;
+ ManuallyTriggeredScheduledExecutorService scheduler =
+ new ManuallyTriggeredScheduledExecutorService();
withStore(
delayMs,
Integer.MAX_VALUE,
+ scheduler,
(store, probe) -> {
+ scheduler.triggerAll();
List<StateChangeSet> changeSets = getChanges(4);
upload(store, changeSets);
assertTrue(probe.getUploaded().isEmpty());
- Thread.sleep(delayMs * 2);
+ assertTrue(
Review comment:
The intention is to check that the delay is equal to what was configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
