pnowojski commented on a change in pull request #16709:
URL: https://github.com/apache/flink/pull/16709#discussion_r682519432
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
##########
@@ -1560,12 +1560,13 @@ public void testProcessWithUnAvailableInput() throws
Exception {
waitingThread::start,
"Start WaitingThread after Task starts processing input.");
- long startTs = System.currentTimeMillis();
- throughputCalculator.calculateThroughput();
Review comment:
is removing this line of code related to the bug? (I don't see how but
it's confusing me a bit)
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
##########
@@ -1560,12 +1560,13 @@ public void testProcessWithUnAvailableInput() throws
Exception {
waitingThread::start,
"Start WaitingThread after Task starts processing input.");
- long startTs = System.currentTimeMillis();
- throughputCalculator.calculateThroughput();
Review comment:
In that case can you extract this to a separate hotfix commit? Mixing
bug fixes and refactoring is very confusing for reviewing and later reading the
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
