srinipunuru commented on pull request #16559: URL: https://github.com/apache/flink/pull/16559#issuecomment-892977621
> Thank you very much for contributing! The code looks quite good already. I made a suggestion to disentangle the abstract factory from the specific factories. > Please double-check the licenses - two new modules are added; just to be safe. > > Concerning testing your changes (and actually also the existing FS): there is now [azurite](https://github.com/Azure/Azurite) available which we could use inside a [testcontainer](https://www.testcontainers.org/) to have an ad-hoc blob storage. It would be a blast if you could add respective ITCases. I can give more detailed pointers or we create a follow-up task. Thanks for the Pointers @AHeise, I did some digging last few days on the azurite. There is good news and bad news, Good news is, It looks like we could use that for testing with Azure storage with wasb:// (which is the legacy hdfs driver). It doesn't yet support the abfs and ADLS Gen2 https://github.com/Azure/Azurite/issues/553. I could add a follow up task to add a end to end test with Azurite for wasb. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
