[ 
https://issues.apache.org/jira/browse/FLINK-23545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393969#comment-17393969
 ] 

jinfeng commented on FLINK-23545:
---------------------------------

[~jark] Thanks for your reply, maybe i didn't express clearly.   After use 
DefaultCatalogTable instead of CatalogTableImpl,  legacy connector will not 
work ,   As cataloTable is DefaultCatalogTable (Unresovled table)     

when execute 
{code:java}
TableFactoryUtil.findAndCreateTableSource(
                        schemaTable.getCatalog(),
                        schemaTable.getTableIdentifier(),
                        catalogTable,
                        new Configuration(),
                        schemaTable.isTemporary());
{code}

It will throw exception `Only a resolved catalog table can be serialized into a 
map of string properties`;


The "COLLECTION"  table  maybe another problem,   TestCollectionTableFactory is 
now a legacy connector, but it has the 'new style' table options.

> Use new schema in SqlCreateTableConverter
> -----------------------------------------
>
>                 Key: FLINK-23545
>                 URL: https://issues.apache.org/jira/browse/FLINK-23545
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / API
>            Reporter: jinfeng
>            Assignee: jinfeng
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.14.0
>
>
> In order to support column comment in sql create table dll. We should  use 
> new schema in SqlCreateeTableConverter. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to