fapaul commented on a change in pull request #16676: URL: https://github.com/apache/flink/pull/16676#discussion_r684150895
########## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/sink/TransactionalIdFactory.java ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.connectors.kafka.sink; + +import org.apache.flink.shaded.guava30.com.google.common.base.Splitter; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.List; +import java.util.Optional; + +class TransactionalIdFactory { + private static final Logger LOG = LoggerFactory.getLogger(TransactionalIdFactory.class); + private static final String TRANSACTIONAL_ID_DELIMITER = "-"; + + /** + * Constructs a transactionalId with the following format {@code + * transactionalIdPrefix-subtaskId-offset}. + * + * @param transactionalIdPrefix prefix for the id + * @param subtaskId describing the subtask which is opening the transaction + * @param offset an always incrementing number usually capturing the number of checkpoints taken + * by the subtask + * @return transactionalId + */ + public static String buildTransactionalId( + String transactionalIdPrefix, int subtaskId, long offset) { Review comment: Hmm, it means we need to instantiate the factory basically for every transaction. What would be the benefit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
