Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2088#discussion_r66804568
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -97,11 +97,26 @@ object CodeGenUtils {
case _ => "null"
}
- def requireNumeric(genExpr: GeneratedExpression) = genExpr.resultType
match {
- case nti: NumericTypeInfo[_] => // ok
- case _ => throw new CodeGenException("Numeric expression type
expected.")
+ def superPrimitive(typeInfo: TypeInformation[_]): String = typeInfo
match {
+ case _: FractionalTypeInfo[_] => "double"
+ case _ => "long"
}
+ //
----------------------------------------------------------------------------------------------
+
+ def requireNumeric(genExpr: GeneratedExpression) =
+ if (!TypeCheckUtils.isNumeric(genExpr.resultType)) {
+ throw new CodeGenException("Numeric expression type expected, but
was " +
+ s"'${genExpr.resultType}'")
+ }
+
+ def requireNumericOrComparable(genExpr: GeneratedExpression) =
--- End diff --
Rename to `requireComparable()`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
