[
https://issues.apache.org/jira/browse/FLINK-23614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395699#comment-17395699
]
Caizhi Weng commented on FLINK-23614:
-------------------------------------
[~paul8263] I believe this class is copied from Calcite. However as it's not
intended to replace the original class in Calcite I think removing unused
methods are reasonable.
To check if a method is really unused it is not enough to see if it is called
in the Flink code base. Some code generation may use these method as a string
literal and we should really check that thoroughly. I think this is a good
point but it may take some effort. What do you think [~lzljs3620320].
> The resulting scale of TRUNCATE(DECIMAL, ...) is not correct
> ------------------------------------------------------------
>
> Key: FLINK-23614
> URL: https://issues.apache.org/jira/browse/FLINK-23614
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Runtime
> Affects Versions: 1.14.0
> Reporter: Caizhi Weng
> Assignee: Yao Zhang
> Priority: Major
> Labels: pull-request-available, starter
>
> Run the following SQL
> {code:sql}
> SELECT
> TRUNCATE(123.456, 2),
> TRUNCATE(123.456, 0),
> TRUNCATE(123.456, -2),
> TRUNCATE(CAST(123.456 AS DOUBLE), 2),
> TRUNCATE(CAST(123.456 AS DOUBLE), 0),
> TRUNCATE(CAST(123.456 AS DOUBLE), -2)
> {code}
> The result is
> {code}
> 123.450
> 123.000
> 100.000
> 123.45
> 123.0
> 100.0
> {code}
> It seems that the resulting scale of {{TRUNCATE(DECIMAL, ...)}} is the same
> as that of the input decimal.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
