Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2085
Thanks for the review! I've addressed almost all your comments and will
ping you once the PR get updated. Some more comments:
> (1) When listing the yarn-session.sh cli options, I could not see the
newly added argument
Fixed. The argument was not printed. The code now prints all available
options.
>Starting a YARN session works. Also, connecting with a second YARN session
works. However, if I'm stopping the session from the second session client, the
first one does not notice this.
It would be good if all connected clients receive the messages, instead of
the last one connected.
Yes, would be nice to have that feature but I think it is out of the scope
of this PR.
>Detached per job submission is not working (./bin/flink run -m
yarn-cluster -yd -yn 1 ./examples/batch/WordCount.jar)
You're running a WordCount with interactive job submission detached. That
doesn't work because the plan can't be extracted in interactive programs
(programs which use count/collect/print).
>While trying out your code, I noticed that the .yarn-properties file is
not properly deleted, even though my previous yarn session was shutting down
correctly:
I'll look into it. I know that this is also an issue in the current master.
I had the properties file lingering around many times. I think it is not
properly cleaned up in the ShutdownHook.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
