zentol commented on a change in pull request #16750:
URL: https://github.com/apache/flink/pull/16750#discussion_r685854332



##########
File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTaskTest.java
##########
@@ -473,7 +473,7 @@ public void testOperatorMetricReuse() throws Exception {
                     @Override
                     public OperatorMetricGroup getOrAddOperator(
                             OperatorID operatorID, String name) {
-                        return new OperatorMetricGroup(
+                        return OperatorMetricGroup.createOperatorMetricGroup(

Review comment:
       hmm could we do something like this?
   
   ```
           TaskMetricGroup taskMetricGroup =
                   new UnregisteredMetricGroups.UnregisteredTaskMetricGroup() {
                       @Override
                       public OperatorMetricGroup getOrAddOperator(
                               OperatorID operatorID, String name) {
                           OperatorMetricGroup operatorMetricGroup = 
super.getOrAddOperator(operatorID, name);
                           operatorMetrics.put(name, operatorMetricGroup);
                           return operatorMetricGroup;
                       }
                   };
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to