edu05 commented on a change in pull request #16652:
URL: https://github.com/apache/flink/pull/16652#discussion_r686363965
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCompletedCheckpointStore.java
##########
@@ -95,18 +86,14 @@ public DefaultCompletedCheckpointStore(
int maxNumberOfCheckpointsToRetain,
StateHandleStore<CompletedCheckpoint, R> stateHandleStore,
CheckpointStoreUtil completedCheckpointStoreUtil,
+ Collection<CompletedCheckpoint> completedCheckpoints,
Executor executor) {
-
checkArgument(maxNumberOfCheckpointsToRetain >= 1, "Must retain at
least one checkpoint.");
-
this.maxNumberOfCheckpointsToRetain = maxNumberOfCheckpointsToRetain;
-
this.checkpointStateHandleStore = checkNotNull(stateHandleStore);
-
this.completedCheckpoints = new
ArrayDeque<>(maxNumberOfCheckpointsToRetain + 1);
Review comment:
not necessary a comment related to this PR's changes but
`maxNumberOfCheckpointsToRetain` does not enforce `completedCheckpoints` from
growing. is that something that needs to be addressed?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCompletedCheckpointStore.java
##########
@@ -95,18 +86,14 @@ public DefaultCompletedCheckpointStore(
int maxNumberOfCheckpointsToRetain,
StateHandleStore<CompletedCheckpoint, R> stateHandleStore,
CheckpointStoreUtil completedCheckpointStoreUtil,
+ Collection<CompletedCheckpoint> completedCheckpoints,
Executor executor) {
-
checkArgument(maxNumberOfCheckpointsToRetain >= 1, "Must retain at
least one checkpoint.");
-
this.maxNumberOfCheckpointsToRetain = maxNumberOfCheckpointsToRetain;
-
this.checkpointStateHandleStore = checkNotNull(stateHandleStore);
-
this.completedCheckpoints = new
ArrayDeque<>(maxNumberOfCheckpointsToRetain + 1);
Review comment:
not necessarily a comment related to this PR's changes but
`maxNumberOfCheckpointsToRetain` does not enforce `completedCheckpoints` from
growing. is that something that needs to be addressed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
