tsreaper commented on pull request #16740: URL: https://github.com/apache/flink/pull/16740#issuecomment-896465161
I've checked this issue again and found that adding tests to `ScalarFunctionsTest.scala` is not enough. This is because function test use the generated function code directly and will not check for the return type of the function. So you may also need to add some tests in `org.apache.flink.table.planner.runtime.batch.sql.CalcITCase`. Also there are CI failures. Please keep an eye on the comment of @flinkbot for the results. If there are CI failures then the PR will never be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
