twalthr commented on a change in pull request #16771:
URL: https://github.com/apache/flink/pull/16771#discussion_r686582381
##########
File path: flink-core/src/main/java/org/apache/flink/api/dag/Transformation.java
##########
@@ -273,7 +273,8 @@ public ResourceSpec getPreferredResources() {
* @param managedMemoryUseCase The use case that this transformation
declares needing managed
* memory for.
* @param weight Use-case-specific weights for this transformation. Used
for sharing managed
- * memory across transformations for OPERATOR scope use cases.
+ * memory across transformations for OPERATOR scope use cases. For
consistency, the APIs
+ * declare their weights as a kibibyte value.
Review comment:
@xintongsong I'm also not happy with this PR. It is only the minimal
solution to make DataStream API batch mode compatible with Table API's batch
mode. A KB unit also has the downside of a potential overflow if the value is
set to high. Also casting `MemorySize.getKibiBytes()` to `int` is not very
nice. Shall we change this to MB instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
