Airblader commented on a change in pull request #16691:
URL: https://github.com/apache/flink/pull/16691#discussion_r686663090
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinition.java
##########
@@ -195,16 +195,31 @@ public Builder notDeterministic() {
return this;
}
+ /**
+ * Specifies that this {@link BuiltInFunctionDefinition} is
implemented during code
+ * generation.
+ */
public Builder runtimeProvided() {
this.isRuntimeProvided = true;
return this;
}
+ /** Specifies the runtime class implementing this {@link
BuiltInFunctionDefinition}. */
public Builder runtimeClass(String runtimeClass) {
this.runtimeClass = runtimeClass;
return this;
}
+ /**
+ * Specifies that this {@link BuiltInFunctionDefinition} will be
mapped to a Calcite
+ * function.
+ */
+ public Builder runtimeDeferred() {
Review comment:
I kind of like `runtimeDeferred` in the sense that the runtime
implementation defers (to Calcite). You marked it a nit, so I'll be cheeky and
ignore it for now, but feel free to make it a stronger opinion. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
