evans-ye commented on a change in pull request #248:
URL: https://github.com/apache/flink-statefun/pull/248#discussion_r686758102
##########
File path:
statefun-e2e-tests/statefun-smoke-e2e-java/src/main/java/org/apache/flink/statefun/e2e/smoke/generated/Command.java
##########
@@ -0,0 +1,5005 @@
+// Generated by the protocol buffer compiler. DO NOT EDIT!
+// source: commands.proto
+
+package org.apache.flink.statefun.e2e.smoke.generated;
Review comment:
OK. I looked into the code and kind of get it. Since no TypedValue is
used in junit runtime, there's no need to resolve the shaded/non-shaded issue.
##########
File path:
statefun-e2e-tests/statefun-smoke-e2e-java/src/main/java/org/apache/flink/statefun/e2e/smoke/generated/Command.java
##########
@@ -0,0 +1,5005 @@
+// Generated by the protocol buffer compiler. DO NOT EDIT!
+// source: commands.proto
+
+package org.apache.flink.statefun.e2e.smoke.generated;
Review comment:
OK. I looked into the code and kind of get it. Since no TypedValue is
used in junit runtime, there's no need to resolve the shaded/non-shaded issue
anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
