zentol commented on a change in pull request #16765:
URL: https://github.com/apache/flink/pull/16765#discussion_r686773943
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/status/job-status.component.html
##########
@@ -51,7 +51,7 @@ <h2>{{ jobDetail.name }}</h2>
<div class="operate">
<span *ngIf="statusTips">{{ statusTips }}</span>
<ng-container *ngIf="!statusTips">
- <a nz-popconfirm nzTitle="Cancel Job?" (nzOnConfirm)="cancelJob()"
*ngIf="webCancelEnabled && (jobDetail.state=='RUNNING' ||
jobDetail.state=='CREATED' || jobDetail.state=='RESTARTING')">Cancel Job</a>
+ <a nz-popconfirm nzTitle="Cancel Job?" nzOkText="Yes"
nzCancelText="No" (nzOnConfirm)="cancelJob()" *ngIf="webCancelEnabled &&
(jobDetail.state=='RUNNING' || jobDetail.state=='CREATED' ||
jobDetail.state=='RESTARTING')">Cancel Job</a>
Review comment:
```suggestion
<a nz-popconfirm nzTitle="Cancel Job?" nzOkText="Yes"
nzCancelText="No" (nzOnConfirm)="cancelJob()" *ngIf="webCancelEnabled &&
(jobDetail.state=='RUNNING' || jobDetail.state=='CREATED' ||
jobDetail.state=='RESTARTING')">Cancel Job</a>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
