zentol commented on a change in pull request #16770: URL: https://github.com/apache/flink/pull/16770#discussion_r686806835
########## File path: flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/groups/OperatorIOMetricGroup.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.metrics.groups; + +import org.apache.flink.metrics.Counter; +import org.apache.flink.metrics.MetricGroup; + +import javax.annotation.concurrent.NotThreadSafe; + +/** + * Metric group that contains shareable pre-defined IO-related metrics for operators. + * + * <p>All metrics can only be accessed in the main operator thread. Review comment: This is a bit misleading for internal usages because we do access metrics outside the operator thread, from the reporter thread. I also wonder whether "can" is the right word; you "can" totally access them from a different thread. You _shouldn't_ though (in general). ########## File path: flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/groups/OperatorIOMetricGroup.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.metrics.groups; + +import org.apache.flink.metrics.Counter; +import org.apache.flink.metrics.MetricGroup; + +import javax.annotation.concurrent.NotThreadSafe; + +/** + * Metric group that contains shareable pre-defined IO-related metrics for operators. + * + * <p>All metrics can only be accessed in the main operator thread. + */ +@NotThreadSafe Review comment: hmm :/ technically the group is thread safe; just the returned counters aren't. ########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java ########## @@ -619,9 +618,7 @@ public StreamTaskStateInitializer createStreamTaskStateInitializer() { protected Counter setupNumRecordsInCounter(StreamOperator streamOperator) { try { - return ((OperatorMetricGroup) streamOperator.getMetricGroup()) - .getIOMetricGroup() - .getNumRecordsInCounter(); + return streamOperator.getMetricGroup().getIOMetricGroup().getNumRecordsInCounter(); Review comment: 🎉 ########## File path: flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/reporter/TestReporter.java ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.metrics.reporter; + +import org.apache.flink.metrics.Metric; +import org.apache.flink.metrics.MetricConfig; +import org.apache.flink.metrics.MetricGroup; + +import java.util.HashMap; +import java.util.Map; +import java.util.Properties; +import java.util.regex.Pattern; +import java.util.stream.Collectors; + +/** A mock implementation that makes all reported metrics available for tests. */ +public class TestReporter implements MetricReporter { + private Map<String, Metric> metrics = new HashMap<>(); + private static final ThreadLocal<TestReporter> REPORTERS = + ThreadLocal.withInitial(TestReporter::new); + + @Override + public void open(MetricConfig config) {} + + @Override + public void close() { + metrics.clear(); + REPORTERS.remove(); + } + + public static TestReporter getInstance() { + return REPORTERS.get(); + } Review comment: nit: move this to the top -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
