PatrickRen commented on a change in pull request #16590:
URL: https://github.com/apache/flink/pull/16590#discussion_r686955548
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,9 @@
+flink-end-to-end-test-common-kafka
Review comment:
```KafkaSourceE2ECase``` requires a JAR of ```kafka-clients``` in the
target/dependencies, so I added it in the ```maven-dependency-plugin```.
Actually it is not packaged into our JAR, but our ```NoticeFileChecker``` is
validating NOTICE file according to the output of
```maven-dependency-plugin```, even the dependency is not packaged in the JAR.
Usage of ```kafka-clients``` in ```KafkaSourceE2ECase```:
https://github.com/apache/flink/pull/16590/files#diff-87acbe4433c51168a661d68dd2c639d22dada8da8b8b890e395e61c4a5ad28eaR54
Usage of ```kafka-clients``` in ```maven-dependency-plugin```:
https://github.com/apache/flink/pull/16590/files#diff-5ed1afac5906e91c880091dee5a33edb9d53aeb0f1f94a88d67319a3844cb43dR225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
