Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2090#discussion_r67010432
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/IOMetricGroup.java ---
@@ -26,33 +26,27 @@
*/
public class IOMetricGroup extends AbstractMetricGroup {
- private final Counter numBytesIn;
private final Counter numBytesOut;
- private final Counter numRecordsIn;
- private final Counter numRecordsOut;
+ private final Counter numBytesInLocal;
+ private final Counter numBytesInRemote;
public IOMetricGroup(MetricRegistry registry, TaskMetricGroup parent) {
super(registry, parent.getScopeComponents());
-
- this.numBytesIn = parent.counter("numBytesIn");
this.numBytesOut = parent.counter("numBytesOut");
- this.numRecordsIn = parent.counter("numRecordsIn");
- this.numRecordsOut = parent.counter("numRecordsOut");
- }
- public Counter getBytesInCounter() {
- return numBytesIn;
+ this.numBytesInLocal = parent.counter("numBytesInLocal");
+ this.numBytesInRemote = parent.counter("numBytesInRemote");
}
public Counter getBytesOutCounter() {
return numBytesOut;
}
- public Counter getRecordsInCounter() {
- return numRecordsIn;
+ public Counter getNumBytesInLocal() {
+ return numBytesInLocal;
}
- public Counter getRecordsOutCounter() {
- return numRecordsOut;
+ public Counter getNumBytesInRemote() {
--- End diff --
rename to `getNumBytesInRemoteCounter`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
