[ 
https://issues.apache.org/jira/browse/FLINK-23729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17398174#comment-17398174
 ] 

Chesnay Schepler commented on FLINK-23729:
------------------------------------------

We should actually remove Cygwin form that list; we neither have automatic 
tests for it, nor check it during release testing, nor even have a single dev 
(that I know of) working with it.

> sql-client.sh fails on Git Bash for Windows, MinGW & MSYS2
> ----------------------------------------------------------
>
>                 Key: FLINK-23729
>                 URL: https://issues.apache.org/jira/browse/FLINK-23729
>             Project: Flink
>          Issue Type: Bug
>          Components: Command Line Client
>    Affects Versions: 1.12.5
>            Reporter: Derek Moore
>            Priority: Major
>              Labels: pull-request-available
>
> sql-client.sh uses manglePath() and manglePathList() from config.sh. These 
> helper functions only recognize "CYGWIN" and not "msys".
> Adding awareness of "msys" allows sql-client.sh to mostly work on Windows.
> The log4j-cli.properties file location is also incorrectly constructed on 
> Windows machines, but this doesn't fail sql-client.sh from loading.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to