dianfu commented on a change in pull request #16732:
URL: https://github.com/apache/flink/pull/16732#discussion_r688188004
##########
File path:
flink-python/src/main/java/org/apache/flink/table/runtime/operators/python/AbstractStatelessFunctionOperator.java
##########
@@ -179,6 +179,10 @@ public PythonFunctionRunner createPythonFunctionRunner()
throws IOException {
if (config.containsKey("table.exec.timezone")) {
jobOptions.put("table.exec.timezone",
config.getString("table.exec.timezone", null));
}
+ if (config.containsKey("loopback.server.address")) {
Review comment:
If moving jobOptions to AbstractPythonFunctionOperator, this could be
removed.
##########
File path:
flink-python/src/main/java/org/apache/flink/streaming/api/operators/python/AbstractOneInputPythonFunctionOperator.java
##########
@@ -57,12 +57,12 @@
private static final long serialVersionUID = 1L;
- /** The options used to configure the Python worker process. */
- private final Map<String, String> jobOptions;
-
/** The TypeInformation of input data. */
private final TypeInformation<IN> inputTypeInfo;
+ /** The options used to configure the Python worker process. */
+ private transient Map<String, String> jobOptions;
Review comment:
Move it to AbstractPythonFunctionOperator
##########
File path:
flink-python/src/main/java/org/apache/flink/streaming/api/operators/python/AbstractPythonFunctionOperator.java
##########
@@ -273,12 +271,12 @@ public boolean isBundleFinished() {
/** Reset the {@link PythonConfig} if needed. */
public void setPythonConfig(PythonConfig pythonConfig) {
- this.config = pythonConfig;
Review comment:
Since pythonConfig is an transient variable, we should refactor this
method to setConfiguration(Configuration conf)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
