Myasuka commented on a change in pull request #16794:
URL: https://github.com/apache/flink/pull/16794#discussion_r688299250
##########
File path:
docs/layouts/shortcodes/generated/rocksdb_configurable_configuration.html
##########
@@ -48,7 +48,7 @@
<td><h5>state.backend.rocksdb.compaction.style</h5></td>
<td style="word-wrap: break-word;">(none)</td>
<td><p>Enum</p></td>
- <td>The specified compaction style for DB. Candidate compaction
style is LEVEL, FIFO or UNIVERSAL, and RocksDB choose 'LEVEL' as default
style.<br /><br />Possible
values:<ul><li>"LEVEL"</li><li>"UNIVERSAL"</li><li>"FIFO"</li></ul></td>
+ <td>The specified compaction style for DB. Candidate compaction
style is LEVEL, FIFO or UNIVERSAL, and RocksDB choose 'LEVEL' as default
style.<br /><br />Possible
values:<ul><li>"LEVEL"</li><li>"UNIVERSAL"</li><li>"FIFO"</li><li>"NONE"</li></ul></td>
Review comment:
If update RocksDB related configurations to latest, I think we should
first update the description of `RocksDBConfigurableOptions#COMPACTION_STYLE`.
BTW, the web documentation should be updated via `mvn package
-Dgenerate-config-docs -pl flink-docs -am -nsu -DskipTests` (refer to
[flink-doc-README](https://github.com/apache/flink/blob/master/flink-docs/README.md))
##########
File path: flink-state-backends/flink-statebackend-rocksdb/pom.xml
##########
@@ -36,6 +36,24 @@ under the License.
<packaging>jar</packaging>
+ <repositories>
+ <repository>
+ <id>sonatype</id>
+ <name>Sonatype repository</name>
Review comment:
Does this repository must exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
