twalthr commented on a change in pull request #16793:
URL: https://github.com/apache/flink/pull/16793#discussion_r688331267
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/FlinkContext.scala
##########
@@ -28,6 +28,11 @@ import org.apache.calcite.plan.Context
*/
trait FlinkContext extends Context {
+ /**
+ * Returns whether the planner runs in batch mode.
+ */
+ def isBatchMode: Boolean
Review comment:
Because batch is a special case of streaming and actually it should be
`isBatchMode` because streaming mode is the default and fallback. When
introducing such a global flag I would rather go with correctness than
consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
