AHeise commented on a change in pull request #16769:
URL: https://github.com/apache/flink/pull/16769#discussion_r688367759
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptionsUtil.java
##########
@@ -535,6 +538,15 @@ private static void autoCompleteSubject(
}
}
+ static void validateDeliveryGuarantee(ReadableConfig tableOptions) {
+ if
(tableOptions.getOptional(DELIVERY_GUARANTEE).orElse(DELIVERY_GUARANTEE.defaultValue())
+ == DeliveryGuarantee.EXACTLY_ONCE
+ &&
!tableOptions.getOptional(TRANSACTIONAL_ID_PREFIX).isPresent()) {
+ throw new ValidationException(
+ "sink.transactional-id-prefix must be specified when using
DeliveryGuarantee.EXACTLY_ONCE.");
Review comment:
I guess we can leave that as a future improvement. We could then also
use it for datastream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
