elphastori opened a new pull request #16815:
URL: https://github.com/apache/flink/pull/16815
## What is the purpose of the change
This pull request unregisters metrics reporting for closed shards in the
Kinesis connector. This avoids confusing and incorrect aggregated metrics after
resharding.
## Brief change log
- ShardConsumerMetricsReporter has an unregister method
- ShardConsumer unregisters ShardConsumerMetricsReporter after consuming
shard
## Verifying this change
This change added tests and can be verified as follows:
- Added unit test that checks that the registered MetricGroup is closed
after a shard completes.
- Manually verified the change by running a Kinesis Data Analytics app
reading from a Kinesis stream with 1 shard then increasing the number of shards
to 2, verifying that the metrics for the closed shard are zeroed in the Flink
dashboard
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
