[
https://issues.apache.org/jira/browse/FLINK-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331341#comment-15331341
]
ASF GitHub Bot commented on FLINK-3650:
---------------------------------------
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1856#discussion_r67117132
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/functions/SelectByMaxFunction.java
---
@@ -36,7 +37,7 @@
* is regarded in the reduce function. First index has highest priority
and last index has
* least priority.
*/
- public SelectByMaxFunction(TupleTypeInfo<T> type, int... fields) {
+ public SelectByMaxFunction(TypeInformation<T> type, int... fields) {
--- End diff --
Done. Since we have added new scala class these changes are unnecessary.
Thanks for pointing it out.
> Add maxBy/minBy to Scala DataSet API
> ------------------------------------
>
> Key: FLINK-3650
> URL: https://issues.apache.org/jira/browse/FLINK-3650
> Project: Flink
> Issue Type: Improvement
> Components: Java API, Scala API
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: ramkrishna.s.vasudevan
>
> The stable Java DataSet API contains the API calls {{maxBy}} and {{minBy}}.
> These methods are not supported by the Scala DataSet API. These methods
> should be added in order to have a consistent API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
