fapaul commented on a change in pull request #16817:
URL: https://github.com/apache/flink/pull/16817#discussion_r688488266
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/watermarkstatus/WatermarkStatus.java
##########
@@ -28,11 +28,11 @@
/**
* A Stream Status element informs stream tasks whether or not they should
continue to expect
Review comment:
Unfortunately, it seems that we also use `Stream status` in our codebase
you probably also need to replace those occurrences.
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/watermarkstatus/StatusWatermarkValve.java
##########
@@ -1,11 +1,10 @@
/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
Review comment:
The formatting changes do not belong to this commit.
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SourceContextWatermarkOutputAdapter.java
##########
@@ -42,4 +42,9 @@ public void emitWatermark(Watermark watermark) {
public void markIdle() {
sourceContext.markAsTemporarilyIdle();
}
+
+ @Override
+ public void markActive() {
+ // will be set active with next watermark
Review comment:
Do we need some kind of follow-up to implement this?
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/watermarkstatus/WatermarkStatus.java
##########
@@ -1,11 +1,10 @@
/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
Review comment:
Same here wrong commit.
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/source/WatermarkToDataOutput.java
##########
@@ -83,4 +80,25 @@ public void markIdle() {
throw new ExceptionInChainedOperatorException(e);
}
}
+
+ @Override
+ public void markActive() {
+ try {
+ markActiveInternally();
+ } catch (ExceptionInChainedOperatorException e) {
+ throw e;
+ } catch (Exception e) {
+ throw new ExceptionInChainedOperatorException(e);
+ }
+ }
Review comment:
Why do we handle the exceptions differently than before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
