AHeise commented on pull request #15304: URL: https://github.com/apache/flink/pull/15304#issuecomment-898876556
> > You will probably get some merge commits with the first commit of https://github.com/apache/flink/pull/16590/commits . You are both adjusting the testcontainer versions. I'm assuming that PR is merged first, so that you would need to solve the conflicts. As far as I can see, PatrickRen's solution should supersede yours and you can simply use his version. > > Please drop the testcontainer version then from your pom.xml. > > It's based on JUnit 5? Cool. I'm working on Unit test. Maybe I could just waiting for this PR. > > I saw that this PR has been merged, thank you. The source test could be change to JUnit 5. Yes you can now use JUnit5 as you wish. It will be encouraged or even forced in the next release cycle. But for now, we should focus on getting the status quo green until Monday noon CEST (feature freeze is EOD CEST afaik). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
