curcur commented on a change in pull request #16808:
URL: https://github.com/apache/flink/pull/16808#discussion_r689066856
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironmentComplexConfigurationTest.java
##########
@@ -141,29 +139,34 @@ public void
testNotOverridingStateBackendWithDefaultsFromConfiguration() {
assertThat(actualStateBackend, instanceOf(MemoryStateBackend.class));
}
- @Test
- public void
testOverridingChangelogStateBackendWithFromConfigurationWhenSet() {
- StreamExecutionEnvironment envFromConfiguration =
- StreamExecutionEnvironment.getExecutionEnvironment();
- assertEquals(
- TernaryBoolean.UNDEFINED,
envFromConfiguration.isChangelogStateBackendEnabled());
-
- Configuration configuration = new Configuration();
- configuration.setBoolean(ENABLE_STATE_CHANGE_LOG, true);
- envFromConfiguration.configure(
- configuration, Thread.currentThread().getContextClassLoader());
- assertEquals(TernaryBoolean.TRUE,
envFromConfiguration.isChangelogStateBackendEnabled());
-
- envFromConfiguration.configure(
- configuration, Thread.currentThread().getContextClassLoader());
- assertEquals(TernaryBoolean.TRUE,
envFromConfiguration.isChangelogStateBackendEnabled());
-
- configuration.setBoolean(ENABLE_STATE_CHANGE_LOG, false);
- envFromConfiguration.configure(
- configuration, Thread.currentThread().getContextClassLoader());
- assertEquals(TernaryBoolean.FALSE,
envFromConfiguration.isChangelogStateBackendEnabled());
- }
-
+ // disabled temporarily
+ // @Test
+ // public void
testOverridingChangelogStateBackendWithFromConfigurationWhenSet() {
+ // StreamExecutionEnvironment envFromConfiguration =
+ // StreamExecutionEnvironment.getExecutionEnvironment();
+ // assertEquals(
+ // TernaryBoolean.UNDEFINED,
+ // envFromConfiguration.isChangelogStateBackendEnabled());
+ //
+ // Configuration configuration = new Configuration();
+ // configuration.setBoolean(ENABLE_STATE_CHANGE_LOG, true);
+ // envFromConfiguration.configure(
+ // configuration,
Thread.currentThread().getContextClassLoader());
+ // assertEquals(TernaryBoolean.TRUE,
+ // envFromConfiguration.isChangelogStateBackendEnabled());
+ //
+ // envFromConfiguration.configure(
+ // configuration,
Thread.currentThread().getContextClassLoader());
+ // assertEquals(TernaryBoolean.TRUE,
+ // envFromConfiguration.isChangelogStateBackendEnabled());
+ //
+ // configuration.setBoolean(ENABLE_STATE_CHANGE_LOG, false);
+ // envFromConfiguration.configure(
+ // configuration,
Thread.currentThread().getContextClassLoader());
+ // assertEquals(TernaryBoolean.FALSE,
+ // envFromConfiguration.isChangelogStateBackendEnabled());
+ // }
+ //
Review comment:
I am not sure we should include this in a formal release.
Or at least make a more concrete comment "disabled temporarily because of
..., will be reenabled after ..."
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogStateBackendLoadingTest.java
##########
@@ -225,16 +227,16 @@ public void
testEnableChangelogStateBackendInStreamExecutionEnvironment() throws
assertTrue(env.getStateBackend() instanceof MemoryStateBackend);
assertStateBackendAndChangelogInEnvironmentAndStreamGraphAndJobGraph(
env, TernaryBoolean.UNDEFINED, MemoryStateBackend.class);
- env.enableChangelogStateBackend(true);
+ // env.enableChangelogStateBackend(true);
Review comment:
at least add a comment to explain this?
Again, I am not sure whether removing it directly would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
