AHeise commented on a change in pull request #16817:
URL: https://github.com/apache/flink/pull/16817#discussion_r689348065
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/eventtime/CombinedWatermarkStatus.java
##########
@@ -69,7 +69,6 @@ public boolean updateCombinedWatermark() {
// if we don't have any outputs minimumOverAllOutputs is not valid,
it's still
// at its initial Long.MAX_VALUE state and we must not emit that
if (partialWatermarks.isEmpty()) {
- this.idle = combinedWatermark > Long.MIN_VALUE;
Review comment:
Good question; I'm also not sure if it's trivial to implement on a
higher level... I'm almost assuming that source implementors need to implement
it themselves. But afaik we also don't encourage it. @dawidwys WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
