Myasuka commented on a change in pull request #16834:
URL: https://github.com/apache/flink/pull/16834#discussion_r689348151
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateOptionTest.java
##########
@@ -52,31 +52,29 @@
import static org.junit.Assert.assertTrue;
/**
- * Tests to cover cases that even user misuse some options, RocksDB
state-backend could still work
- * as expected or give explicit feedback.
+ * Tests to cover cases that if user choose options previously prone to
misuse, embedded RocksDB
+ * state-backend could still work as expected or give explicit feedback.
*
* <p>RocksDB state-backend has some internal operations based on RocksDB's
APIs which is
* transparent for users. However, user could still configure options via
{@link
* RocksDBOptionsFactory}, and might lead some operations could not get
expected result, e.g.
* FLINK-17800
*/
-public class RocksDBStateMisuseOptionTest {
+public class RocksDBStateOptionTest {
@Rule public final TemporaryFolder tempFolder = new TemporaryFolder();
/**
- * Tests to cover case when user misuse optimizeForPointLookup with
iterator interfaces on map
+ * Tests to cover case when user choose optimizeForPointLookup with
iterator interfaces on map
* state.
- *
- * <p>The option {@link ColumnFamilyOptions#optimizeForPointLookup(long)}
would lead to
- * iterator.seek with prefix bytes invalid.
*/
@Test
public void testMisuseOptimizePointLookupWithMapState() throws Exception {
- RocksDBStateBackend rocksDBStateBackend =
createStateBackendWithOptimizePointLookup();
+ EmbeddedRocksDBStateBackend rocksDBStateBackend =
Review comment:
OK, I'll remove these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
