NicoK commented on pull request #8344: URL: https://github.com/apache/flink/pull/8344#issuecomment-899352446
I went ahead and rebased this commit onto the latest master. I also improved a few things such as: - reduce code duplication with the existing `TypeInfoFactory` handling (this also adds a couple of validity checks for the annotation and the type that the `TypeInfoFactory` returns) - extended the tests (overriding a class-defined `TypeInfoFactory` works, types without generics work) I would consider this my review, but if any of the people involved in this thread wants to take a second look that would be great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
