Thesharing commented on a change in pull request #16724:
URL: https://github.com/apache/flink/pull/16724#discussion_r689477143
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java
##########
@@ -63,21 +63,21 @@
code("fixeddelay"),
code("fixed-delay"),
link(
-
"../../ops/state/task_failure_recovery#fixed-delay-restart-strategy",
+
"{{.Site.BaseURL}}docs/ops/state/task_failure_recovery#fixed-delay-restart-strategy",
"here")),
text(
"%s, %s: Failure rate
restart strategy. More details can be found %s.",
code("failurerate"),
code("failure-rate"),
link(
-
"../../ops/state/task_failure_recovery#failure-rate-restart-strategy",
+
"{{.Site.BaseURL}}docs/ops/state/task_failure_recovery#failure-rate-restart-strategy",
"here")),
text(
"%s, %s: Exponential delay
restart strategy. More details can be found %s.",
code("exponentialdelay"),
code("exponential-delay"),
link(
-
"../../ops/state/task_failure_recovery#exponential-delay-restart-strategy",
+
"{{.Site.BaseURL}}docs/ops/state/task_failure_recovery#exponential-delay-restart-strategy",
Review comment:
> maybe `{{.Site.BaseURL}}/docs` to be safer?
Yes, it will make sure the URL won't be broken if `{{.Site.BaseURL}}` is not
ended with `/`. But for now it will make the URL as
`https://ci.apache.org/projects/flink/flink-docs-master//docs/ops/state/task_failure_recovery/`,
would it be okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
