nicoweidner commented on a change in pull request #16807:
URL: https://github.com/apache/flink/pull/16807#discussion_r689498602
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.html
##########
@@ -40,23 +40,25 @@
<ng-container *ngFor="let exception of
listOfException;trackBy:trackExceptionBy;">
<tr>
<td nzShowExpand [(nzExpand)]="exception.expand"></td>
- <td>{{exception.timestamp | date:'yyyy-MM-dd HH:mm:ss'}}</td>
- <td><div class="name">{{exception.exceptionName}}</div></td>
+ <td>{{exception.selected.timestamp | date:'yyyy-MM-dd
HH:mm:ss'}}</td>
+ <td><div
class="name">{{exception.selected.exceptionName}}</div></td>
<td>
- <div class="name">
- {{exception.taskName || "(global failure)"}}
- </div>
+ <nz-select style="width: 300px;"
[nzDisabled]="exception.values.length == 1" nzShowSearch
[(ngModel)]="exception.selected">
Review comment:
I have a slight preference to just not disable it in the case of a
single option, but it's fine either way!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
