twalthr commented on a change in pull request #16809:
URL: https://github.com/apache/flink/pull/16809#discussion_r689531380
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicSource.java
##########
@@ -201,10 +221,32 @@ public ScanRuntimeProvider
getScanRuntimeProvider(ScanContext context) {
final TypeInformation<RowData> producedTypeInfo =
context.createTypeInformation(producedDataType);
- final FlinkKafkaConsumer<RowData> kafkaConsumer =
- createKafkaConsumer(keyDeserialization, valueDeserialization,
producedTypeInfo);
+ if (fallbackToFlinkKafkaConsumer) {
+ final FlinkKafkaConsumer<RowData> kafkaConsumer =
+ createKafkaConsumer(keyDeserialization,
valueDeserialization, producedTypeInfo);
+ return SourceFunctionProvider.of(kafkaConsumer, false);
+ }
- return SourceFunctionProvider.of(kafkaConsumer, false);
+ final KafkaSource<RowData> kafkaSource =
+ createKafkaSource(keyDeserialization, valueDeserialization,
producedTypeInfo);
+
+ return new DataStreamScanProvider() {
Review comment:
Actually, fixing this would have been part of the Kafka source issue as
it is the first production ready streaming source with watermarks. But let's
postpone it after feature freeze now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
