twalthr commented on a change in pull request #16788:
URL: https://github.com/apache/flink/pull/16788#discussion_r689548176
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala
##########
@@ -18,24 +18,34 @@
package org.apache.flink.table.planner.delegation
+import java.lang.{Long => JLong}
Review comment:
still wrong import order?
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/EnvironmentSettings.java
##########
@@ -211,34 +207,23 @@ public boolean isBlinkPlanner() {
return true;
}
- /** Returns the {@link Executor} that should submit and execute table
programs. */
+ /** Returns the identifier of the {@link Planner} to be used. */
@Internal
- public String getExecutor() {
- return executor;
+ public String getPlanner() {
+ return planner;
}
+ /** Returns the {@link Executor} that should submit and execute table
programs. */
@Internal
- public Map<String, String> toPlannerProperties() {
- Map<String, String> properties = new HashMap<>(toCommonProperties());
- if (plannerClass != null) {
- properties.put(CLASS_NAME, plannerClass);
- }
- return properties;
- }
-
- private Map<String, String> toCommonProperties() {
- Map<String, String> properties = new HashMap<>();
- properties.put(STREAMING_MODE, Boolean.toString(isStreamingMode));
- return properties;
+ public String getExecutor() {
+ return executor;
}
/** A builder for {@link EnvironmentSettings}. */
public static class Builder {
- private static final String BLINK_PLANNER_FACTORY =
-
"org.apache.flink.table.planner.delegation.BlinkPlannerFactory";
+ private final String planner = PlannerFactory.DEFAULT_PLANNER;
Review comment:
`DEFAULT_PLANNER` -> `DEFAULT_IDENTIFIER`
##########
File path:
flink-connectors/flink-connector-hive/src/main/resources/META-INF/services/org.apache.flink.table.factories.TableFactory
##########
@@ -13,4 +13,3 @@
# See the License for the specific language governing permissions and
# limitations under the License.
Review comment:
remove file entirely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
