[
https://issues.apache.org/jira/browse/FLINK-23454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399783#comment-17399783
]
Anton Kalashnikov commented on FLINK-23454:
-------------------------------------------
Merged to master from 77f7b7f0f90725fcc65144fa86572d16314f3d0a to
545b6126cc42c5c9bce8783931b04a3bec571aa6
> Sending the buffer of the right size for unicast
> ------------------------------------------------
>
> Key: FLINK-23454
> URL: https://issues.apache.org/jira/browse/FLINK-23454
> Project: Flink
> Issue Type: Sub-task
> Reporter: Anton Kalashnikov
> Assignee: Anton Kalashnikov
> Priority: Major
> Labels: pull-request-available
>
> It is not enough to know just the number of available buffers (credits) for
> the downstream because the size of these buffers can be different. So we are
> proposing to resolve this problem in the following way: If the downstream
> buffer size is changed then the upstream should send the buffer of the size
> not greater than the new one regardless of how big the current buffer on the
> upstream. (pollBuffer should receive parameters like bufferSize and return
> buffer not greater than it)
> Downstream will be able to support any buffer size < max buffer size, so it
> should be just good enough to request BufferBuilder with new size after
> getting announcement, and leaving existing BufferBuilder/BufferConsumers
> unchanged. In other words code in {{PipelinedSubpartition(View)}} doesn’t
> need to be changed (apart of forwarding new buffer size to the
> {{BufferWritingResultPartition}}). All buffer size adjustments can be
> implemented exclusively in {{BufferWritingResultPartition}}.
> If different downstream subtasks have different throughput and hence
> different desired buffer sizes, then a single upstream subtask has to support
> having two different subpartitions with different buffer sizes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
