curcur edited a comment on pull request #16844: URL: https://github.com/apache/flink/pull/16844#issuecomment-900796934
Synced up offline. Thanks Yingjie @wsry for the explanation! I am fine with the change. Please add three comments/explanations either in the code or in this PR (I will also comment inline). 1. Why adding `closebufferpool()` in `fail()` 2. Why changing "closeResources" -> `fail` is necesary in task cancler. 3. Why the refactoring is necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
