AHeise commented on a change in pull request #16851:
URL: https://github.com/apache/flink/pull/16851#discussion_r691197520
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -461,8 +462,9 @@ public MetricTrackingOutput(
public void emitRecord(StreamRecord<OUT> streamRecord) throws
Exception {
output.emitRecord(streamRecord);
this.sourceMetricGroup.recordEmitted();
- if (streamRecord.hasTimestamp()) {
-
this.sourceMetricGroup.eventTimeEmitted(streamRecord.getTimestamp());
+ long timestamp = streamRecord.getTimestamp();
+ if (timestamp != TimestampAssigner.NO_TIMESTAMP) {
Review comment:
It doesn't make sense to keep the check as
`SourceOutputWithWatermarks#collect` will never set the flag.
But I created https://issues.apache.org/jira/browse/FLINK-23858 to clarify
it further and potentially deprecate the old uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
