[
https://issues.apache.org/jira/browse/FLINK-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331788#comment-15331788
]
ASF GitHub Bot commented on FLINK-4063:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2106
well it would work, but i think we can improve it a little. :)
The AbstractStreamOperator contains a protected MetricGroup field which you
can use in the WindowOperator instead of going through the RuntimeContext. You
can access it directly or via getMetricGroup().
Also, you create 2 groups with a constant name. This means that all metrics
that are registered in a trigger now contain "WindowOperator.Trigger" in their
final metric name.
Now the Trigger group is probably _fine_, but is now also mandatory. I
would prefer removing it; if users want to group their metrics by Trigger they
can easily do so themselves.
The WindowOperator group should be removed. It is inconsistent with other
operators and provides no really specific information. It will usually be
redundant since the operator name often contains the String "window" somewhere.
> Add Metrics Support for Triggers
> --------------------------------
>
> Key: FLINK-4063
> URL: https://issues.apache.org/jira/browse/FLINK-4063
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Affects Versions: 1.1.0
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> Now that we have proper support for metrics we should also add a hook that
> allows triggers to report metrics.
> This supersedes FLINK-3758 which was about using accumulators for metrics in
> triggers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
