zhuzhurk commented on a change in pull request #16856:
URL: https://github.com/apache/flink/pull/16856#discussion_r692056461



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java
##########
@@ -1279,10 +1279,14 @@ private void releasePartitions(final 
List<IntermediateResultPartitionID> releasa
 
             // Remove cached ShuffleDescriptor when partition is released
             releasablePartitions.stream()
-                    
.map(IntermediateResultPartitionID::getIntermediateDataSetID)
+                    .map(edgeManager::getConsumedPartitionGroupsById)

Review comment:
       I think you are right! @tillrohrmann 
   We can simplify `getConsumedPartitionGroupsById` to  
`getConsumedPartitionGroupById` and guard it with check that a partition must 
not be assigned to multiple `ConsumedPartitionGroup`s. I would not require much 
effort I believe.
   Later we can do the refactor work to get rid of the assumption that one 
`IntermediateDataSet` can have multiple consumer `JobVertex` to further 
simplify things (FLINK-18295).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to