dmvk commented on a change in pull request #16884:
URL: https://github.com/apache/flink/pull/16884#discussion_r692094697
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/IOManager.java
##########
@@ -54,6 +56,14 @@
protected IOManager(String[] tempDirs) {
this.fileChannelManager =
new
FileChannelManagerImpl(Preconditions.checkNotNull(tempDirs), DIR_NAME_PREFIX);
+ if (LOG.isInfoEnabled()) {
+ LOG.info(
+ "Created a new {} for spilling of task related data to
disk (joins, sorting, ...). Used directories: {}.",
+ FileChannelManager.class.getSimpleName(),
+ Arrays.stream(fileChannelManager.getPaths())
+ .map(File::getAbsolutePath)
+ .collect(Collectors.joining(", ")));
Review comment:
I'd strongly recommend against multi-line log messages, because this
would affect logging infrastructure of many users.
For tools such as fluentd, filebeat, logstash, that rely on log parsing,
this would require special handling [1]. One special case of multiline log are
stacktraces, but these have a well defined format and are usually supported out
of the box.
[1]
https://www.elastic.co/guide/en/beats/filebeat/current/multiline-examples.html#multiline-examples
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
