akalash commented on a change in pull request #16885:
URL: https://github.com/apache/flink/pull/16885#discussion_r692370716
##########
File path:
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/output/BoundedStreamTask.java
##########
@@ -116,7 +116,7 @@ protected void processInput(MailboxDefaultAction.Controller
controller) throws E
protected void cancelTask() {}
@Override
- protected void cleanup() throws Exception {
+ protected void cleanUpInternal() throws Exception {
Review comment:
Yes, I think you can leave as is. I just emphasized that we have two
methods with similar names and it is not clear which method should be
overridden in which case. I mean having the one main method `cleanUp` which use
several abstract(or just protected methods) like `cleanUpOperator`,
`cleanUpTimers`, etc. is pretty understandable but having one `cleanUp` inside
of another `cleanUp` is not so understandable. But I agree that it is not easy
to come up with a good name because it is indeed the cleanUp so let's leave it
as `cleanUpInternal`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
