[
https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated FLINK-4053:
--------------------------
Description:
In RMQSource.java and RMQSink.java, there is code in the following pattern:
{code}
connection = factory.newConnection();
channel = connection.createChannel();
{code}
According to
https://www.rabbitmq.com/releases/rabbitmq-java-client/current-javadoc/com/rabbitmq/client/Connection.html#createChannel()
:
{code}
Returns:
a new channel descriptor, or null if none is available
{code}
The return value should be checked against null.
was:
In RMQSource.java and RMQSink.java, there is code in the following pattern:
{code}
connection = factory.newConnection();
channel = connection.createChannel();
{code}
According to
https://www.rabbitmq.com/releases/rabbitmq-java-client/current-javadoc/com/rabbitmq/client/Connection.html#createChannel()
:
{code}
Returns:
a new channel descriptor, or null if none is available
{code}
The return value should be checked against null.
> Return value from Connection should be checked against null
> -----------------------------------------------------------
>
> Key: FLINK-4053
> URL: https://issues.apache.org/jira/browse/FLINK-4053
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> In RMQSource.java and RMQSink.java, there is code in the following pattern:
> {code}
> connection = factory.newConnection();
> channel = connection.createChannel();
> {code}
> According to
> https://www.rabbitmq.com/releases/rabbitmq-java-client/current-javadoc/com/rabbitmq/client/Connection.html#createChannel()
> :
> {code}
> Returns:
> a new channel descriptor, or null if none is available
> {code}
> The return value should be checked against null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
