[
https://issues.apache.org/jira/browse/FLINK-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402321#comment-17402321
]
Till Rohrmann commented on FLINK-9925:
--------------------------------------
I think the problem is that the channel handlers are not shareable:
{code}
================================================================================
Test testSimpleRequests(org.apache.flink.queryablestate.network.ClientTest) is
running.
--------------------------------------------------------------------------------
23:22:37,142 [nioEventLoopGroup-4-3] WARN
org.apache.flink.shaded.netty4.io.netty.channel.ChannelInitializer [] - Failed
to initialize a channel. Closing: [id: 0xe7e8b2bb, L:/192.168.192.2:33856 -
R:/192.168.192.2:33078]
org.apache.flink.shaded.netty4.io.netty.channel.ChannelPipelineException:
org.apache.flink.queryablestate.network.ClientTest$1 is not a @Sharable
handler, so can't be added or removed multiple times.
at
org.apache.flink.shaded.netty4.io.netty.channel.DefaultChannelPipeline.checkMultiplicity(DefaultChannelPipeline.java:600)
~[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.DefaultChannelPipeline.addLast(DefaultChannelPipeline.java:202)
~[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.DefaultChannelPipeline.addLast(DefaultChannelPipeline.java:381)
~[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.DefaultChannelPipeline.addLast(DefaultChannelPipeline.java:370)
~[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.queryablestate.network.ClientTest$5.initChannel(ClientTest.java:897)
~[test-classes/:?]
at
org.apache.flink.queryablestate.network.ClientTest$5.initChannel(ClientTest.java:890)
~[test-classes/:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.ChannelInitializer.initChannel(ChannelInitializer.java:129)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.ChannelInitializer.handlerAdded(ChannelInitializer.java:112)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.callHandlerAdded(AbstractChannelHandlerContext.java:938)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.DefaultChannelPipeline.callHandlerAdded0(DefaultChannelPipeline.java:609)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.DefaultChannelPipeline.access$100(DefaultChannelPipeline.java:46)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.DefaultChannelPipeline$PendingHandlerAddedTask.execute(DefaultChannelPipeline.java:1463)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.DefaultChannelPipeline.callHandlerAddedForAllHandlers(DefaultChannelPipeline.java:1115)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.DefaultChannelPipeline.invokeHandlerAddedIfNeeded(DefaultChannelPipeline.java:650)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannel$AbstractUnsafe.register0(AbstractChannel.java:502)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannel$AbstractUnsafe.access$200(AbstractChannel.java:417)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannel$AbstractUnsafe$1.run(AbstractChannel.java:474)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at
org.apache.flink.shaded.netty4.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
[flink-shaded-netty-4.1.49.Final-13.0.jar:?]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_282]
23:22:56,902 [ main] ERROR
org.apache.flink.queryablestate.network.ClientTest [] -
--------------------------------------------------------------------------------
Test testSimpleRequests(org.apache.flink.queryablestate.network.ClientTest)
failed with:
java.lang.AssertionError: Receive timed out
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertNotNull(Assert.java:712)
at
org.apache.flink.queryablestate.network.ClientTest.testSimpleRequests(ClientTest.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at
org.apache.flink.util.TestNameProvider$1.evaluate(TestNameProvider.java:45)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
{code}
I cannot explain why multiple pipelines are being created but if this happens,
then the pipeline will fail because the handler cannot be reused. I propose to
change this since the problematic handler is stateless.
> ClientTest.testSimpleRequests fails on Travis
> ---------------------------------------------
>
> Key: FLINK-9925
> URL: https://issues.apache.org/jira/browse/FLINK-9925
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Queryable State, Tests
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Priority: Major
> Labels: auto-deprioritized-critical, test-stability
>
> {{ClientTest.testSimpleRequests}} fails on Travis with an {{AssertionError}}:
> https://api.travis-ci.org/v3/job/405690023/log.txt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
